-
Notifications
You must be signed in to change notification settings - Fork 525
[amazon_bedrock_agentcore] add gateway_application_logs data stream #15991
#16587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
| type: keyword | ||
| description: ID of the processed request. | ||
|
|
||
| - name: body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the agentcore runtime application log request_payload_object is used as the field name for the flattened field. Can a similar naming convention be followed here, such as payload_object ?
| "body": { | ||
| "id": "7", | ||
| "isError": false, | ||
| "log": "Processing request for tool DocumentRetrieval___fetch_order_details from target XYZPROD001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the key parts of this and store them in ECS fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The body.log field does not always follow a consistent format. In some cases, we may be able to extract values such as the tool name and target but these fields will not be present in all gateway logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the gateway, the tool operation name, target, and outcome of the tool operation (including target invocation results) are important observability information. When present, let's capture it and store them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you may store the log data entirely in the messsage field
💚 Build Succeeded
History
cc @gpop63 |
agithomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
This PR adds the
gateway_application_logsdata stream.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots