-
Notifications
You must be signed in to change notification settings - Fork 525
Move Hosted Services dashboards to Links Panels #14847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
| "params": { | ||
| "fontSize": 12, | ||
| "markdown": "**Navigation**\n\n**[Logs AWS] Guardduty Findings Overview**\n\n[[Logs AWS] Guardduty Findings Severity](/app/dashboards#/view/aws-401261a0-6a39-11ed-b880-2f1b70138655)\n\n[[Logs AWS] Guardduty Findings Threat](/app/dashboards#/view/aws-f890a5b0-6a3a-11ed-b880-2f1b70138655)\n\n**Overview**\n\nThis dashboard provides an overview of security findings detected by AWS GuardDuty, helping security teams identify key trends and patterns. It highlights the top affected AWS accounts and the findings with the highest confidence scores, allowing for prioritization of high-risk issues. Additional visualizations display the distribution of findings by action type and threat type, supporting deeper investigation into the nature and behavior of threats. Detailed tables further enrich the context by listing essential data for each finding, facilitating swift incident response and root cause analysis.", | ||
| "markdown": "**Overview** of security findings detected by AWS GuardDuty, helping security teams identify key trends and patterns. It highlights the top affected AWS accounts and the findings with the highest confidence scores, allowing for prioritization of high-risk issues. Additional visualizations display the distribution of findings by action type and threat type, supporting deeper investigation into the nature and behavior of threats. Detailed tables further enrich the context by listing essential data for each finding, facilitating swift incident response and root cause analysis.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you removed the extra links on top. Now the navigation is on it own box. Tested it and looks ok
| "y": 0 | ||
| }, | ||
| "panelIndex": "14a16e94-f5b1-403c-9087-d90b8891acf5", | ||
| "title": "Top 10 Findings ARN with Highest Confidence Score [Logs Guardduty]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This is a general comment for all the titles: Why you removed the extra explanatory brackets [], eg here [Logs Guardduty] . Do you think it does not provide any extra help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't have a strong opinion on it. But we are describing here that we should not have that in the title. That is why I removed it. Happy to place it back if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I will also leave the security team to comment on this.
Reading again your link (which confused me a bit) and adding also this, I guess the removal applies only for the visualsiation titles inside a dashboard. Not to repeat the same brackets again and again.
But when you give a dashboard name or a link to it (in our case) it is good to have the [Metrics | Logs Package] (at least this is how I translated above and this is what we do also in other cases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't touch the Dashboard names, I only removed it from panel titles.
|
LGTM and tested it also locally and seems ok. It would be useful to add also 1-2 screenshots for AWS in the description |
|
@TimBosman this screenshot is the old/existing aws.guarduty right? Might be misleading for someone that sees the description. Can you add a comment please? |
|
I edited it again. You are correct, they were in a random order that was confusing |
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
💔 Build Failed
Failed CI StepsHistory
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
|
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |




Proposed commit message
As described in issue #14502, Dashboards need to move away from using
/app/dashboardand#/dashboard/Markdown links to a Links panelChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Build the packages and verify the new Links panels
Related issues
Screenshots
Azure Storage








Istio
AWS
Before:
After: