Skip to content

Conversation

@TimBosman
Copy link
Contributor

@TimBosman TimBosman commented Aug 6, 2025

Proposed commit message

As described in issue #14502, Dashboards need to move away from using /app/dashboard and #/dashboard/ Markdown links to a Links panel

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Build the packages and verify the new Links panels

Related issues

Screenshots

Azure Storage
Screenshot 2025-07-28 at 21 40 45
Screenshot 2025-07-26 at 20 30 13
Istio
Screenshot 2025-07-26 at 20 24 28
Screenshot 2025-07-26 at 20 17 37
AWS
Before:
Screenshot 2025-08-07 at 10 13 56
Screenshot 2025-08-07 at 10 13 36
After:
Screenshot 2025-08-07 at 10 16 37
Screenshot 2025-08-07 at 10 18 23

@TimBosman TimBosman added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Aug 6, 2025
@TimBosman TimBosman marked this pull request as ready for review August 6, 2025 18:24
@TimBosman TimBosman requested review from a team as code owners August 6, 2025 18:24
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 6, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] label Aug 6, 2025
"params": {
"fontSize": 12,
"markdown": "**Navigation**\n\n**[Logs AWS] Guardduty Findings Overview**\n\n[[Logs AWS] Guardduty Findings Severity](/app/dashboards#/view/aws-401261a0-6a39-11ed-b880-2f1b70138655)\n\n[[Logs AWS] Guardduty Findings Threat](/app/dashboards#/view/aws-f890a5b0-6a3a-11ed-b880-2f1b70138655)\n\n**Overview**\n\nThis dashboard provides an overview of security findings detected by AWS GuardDuty, helping security teams identify key trends and patterns. It highlights the top affected AWS accounts and the findings with the highest confidence scores, allowing for prioritization of high-risk issues. Additional visualizations display the distribution of findings by action type and threat type, supporting deeper investigation into the nature and behavior of threats. Detailed tables further enrich the context by listing essential data for each finding, facilitating swift incident response and root cause analysis.",
"markdown": "**Overview** of security findings detected by AWS GuardDuty, helping security teams identify key trends and patterns. It highlights the top affected AWS accounts and the findings with the highest confidence scores, allowing for prioritization of high-risk issues. Additional visualizations display the distribution of findings by action type and threat type, supporting deeper investigation into the nature and behavior of threats. Detailed tables further enrich the context by listing essential data for each finding, facilitating swift incident response and root cause analysis.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you removed the extra links on top. Now the navigation is on it own box. Tested it and looks ok

"y": 0
},
"panelIndex": "14a16e94-f5b1-403c-9087-d90b8891acf5",
"title": "Top 10 Findings ARN with Highest Confidence Score [Logs Guardduty]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This is a general comment for all the titles: Why you removed the extra explanatory brackets [], eg here [Logs Guardduty] . Do you think it does not provide any extra help?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't have a strong opinion on it. But we are describing here that we should not have that in the title. That is why I removed it. Happy to place it back if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will also leave the security team to comment on this.
Reading again your link (which confused me a bit) and adding also this, I guess the removal applies only for the visualsiation titles inside a dashboard. Not to repeat the same brackets again and again.

But when you give a dashboard name or a link to it (in our case) it is good to have the [Metrics | Logs Package] (at least this is how I translated above and this is what we do also in other cases)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't touch the Dashboard names, I only removed it from panel titles.

@gizas
Copy link
Contributor

gizas commented Aug 7, 2025

LGTM and tested it also locally and seems ok. It would be useful to add also 1-2 screenshots for AWS in the description

@gizas
Copy link
Contributor

gizas commented Aug 7, 2025

@TimBosman this screenshot is the old/existing aws.guarduty right?

Might be misleading for someone that sees the description. Can you add a comment please?

@TimBosman
Copy link
Contributor Author

I edited it again. You are correct, they were in a random order that was confusing

@elastic-sonarqube
Copy link

@andrewkroh andrewkroh added the enhancement New feature or request label Aug 7, 2025
@botelastic
Copy link

botelastic bot commented Sep 6, 2025

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 6, 2025
@botelastic botelastic bot removed the Stalled label Sep 17, 2025
@elastic-sonarqube
Copy link

@botelastic
Copy link

botelastic bot commented Oct 17, 2025

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 17, 2025
@botelastic botelastic bot removed the Stalled label Nov 9, 2025
@elasticmachine
Copy link

elasticmachine commented Nov 10, 2025

💔 Build Failed

Failed CI Steps

History

@botelastic
Copy link

botelastic bot commented Dec 10, 2025

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 10, 2025
@botelastic
Copy link

botelastic bot commented Jan 9, 2026

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:aws AWS Integration:azure_metrics Azure Resource Metrics Integration:azure Azure Logs Integration:istio Istio Stalled Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants