Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiIcon] Add section glyph #8261

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[EuiIcon] Add section glyph #8261

merged 2 commits into from
Jan 8, 2025
+58 −4

Conversation

andreadelrio
Copy link
Contributor

Summary

image

In context:

Start - Flyout open

General checklist

  • Checked in both light and dark modes
  • Added or updated jest tests
  • A changelog entry exists and is marked appropriately.

@andreadelrio andreadelrio requested a review from a team as a code owner January 8, 2025 01:40
@mgadewoll
Copy link
Contributor

@andreadelrio I added a changelog to your branch to unblock the pipeline, hope you don't mind!

Fyi, to generate a changelog you can run the following in packages/eui:

  • yarn yo-changelog {PR_NUMBER}
  • answer the questions in the console based on the changes

This generates a template changelog file that you then need to fill out.

mgadewoll
mgadewoll approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Changes look good to me. The new icon is available in our docs as expected. 👍
Thanks for contributing!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 2bbe8cf into elastic:main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreadelrio @mgadewoll @kibanamachine @elasticmachine