Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Remove hasDragDrop deprecated prop #8256

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

acstll
Copy link
Contributor

@acstll acstll commented Dec 30, 2024

Summary

See #1469 (December)

  • hasDragDrop – 0 usages in Kibana / ? usages in Cloud

QA

I would suggest looking for any leftovers I couldn't find.

General checklist

  • Browser QA
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

Copy link

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • Search through Kibana for <EuiComponent usages (example search)
    • In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • If this PR contains CSS changes:
    • Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
    • In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • 🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
  • ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
    • Using a pre-release release candidate to test Kibana CI ahead of time
    • Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

@acstll acstll marked this pull request as ready for review December 31, 2024 09:34
@acstll acstll requested a review from a team as a code owner December 31, 2024 09:34
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ The changes LGTM, thanks for the cleanup!
I checked in Kibana and Cloud and could not find any usages of hasDragDrop either.

packages/eui/changelogs/upcoming/8256.md Outdated Show resolved Hide resolved
@acstll acstll force-pushed the popover-remove-hasdragdrop-prop branch from 03c6243 to bb391a8 Compare January 7, 2025 09:08
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@acstll acstll merged commit a28fd7f into elastic:main Jan 7, 2025
5 checks passed
@acstll acstll deleted the popover-remove-hasdragdrop-prop branch January 7, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants