-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPopover] Remove hasDragDrop
deprecated prop
#8256
Conversation
This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🐈⬛ The changes LGTM, thanks for the cleanup!
I checked in Kibana and Cloud and could not find any usages of hasDragDrop
either.
03c6243
to
bb391a8
Compare
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Summary
See #1469 (December)
hasDragDrop
– 0 usages in Kibana / ? usages in CloudQA
I would suggest looking for any leftovers I couldn't find.
General checklist
Browser QAAdded documentationProps have proper autodocs (using@default
if default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsUpdated visual regression testsIf applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)