Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Severity palette order for Amsterdam #8254

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

acstll
Copy link
Contributor

@acstll acstll commented Dec 30, 2024

Summary

Note

This PR merges into a feature branch.

This PR introduces no changes in the implementation of the new Severity palette.

It only fixes a mistake in the implementation (#8247), where the values for the severity levels from 1 (low) to 14 (high) were inverted for the Amsterdam theme. Thank you @maxcold for reporting.

Before After
Screenshot 2024-12-30 at 12 37 13 Screenshot 2024-12-30 at 12 27 32

QA

Probably not needed, but an extra manual double-check wouldn't hurt.

@acstll acstll requested a review from a team as a code owner December 30, 2024 11:41
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🙏
My brain was somewhere else it seems when adding those 🙈

@acstll acstll merged commit 615e56b into elastic:eui-theme/borealis Jan 7, 2025
5 checks passed
@acstll acstll deleted the severity-amsterdam-order branch January 7, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants