-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual Refresh] Add behindText vis color tokens #8253
[Visual Refresh] Add behindText vis color tokens #8253
Conversation
755606d
to
7528314
Compare
packages/eui-theme-common/src/global_styling/variables/colors.ts
Outdated
Show resolved
Hide resolved
packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.ts
Outdated
Show resolved
Hide resolved
ℹ️ FYI I realized we have a breaking test due to the new year. I added the fix here on I'll add the fix to this PR to be able to add the changes, but I will wait until the actual fix PR is reviewed and merged to rebase Borealis. |
615e56b
to
d1e1f1c
Compare
67971c8
to
e1109c1
Compare
ℹ️ I rebased this branch with the updated Borealis feature branch that includes the test pipeline fix. |
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Summary
Note
This PR merges into a feature branch.
This PR adds
_behindText
vis color tokens. These have not been part of the theme, as they are not in usage in the new theme.During upgrades to the new theme, we realized that it's rather cumbersome for teams to migrate these JSON token usages properly to the
euiTheme
tokens without a 1:1 equivalent.These tokens are temporary for the purpose of making migration easier for Kibana teams. We will need to remove those tokens again at some point as they are not be used in Borealis.
QA
These tokens are not used anywhere. Make sure the values make sense:
Amsterdam - uses values returned from
euiPaletteColorBlindBehindText()
Borealis maps to default vis colors
CI passes