Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Add behindText vis color tokens #8253

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Dec 19, 2024

Summary

Note

This PR merges into a feature branch.

This PR adds _behindText vis color tokens. These have not been part of the theme, as they are not in usage in the new theme.
During upgrades to the new theme, we realized that it's rather cumbersome for teams to migrate these JSON token usages properly to the euiTheme tokens without a 1:1 equivalent.

These tokens are temporary for the purpose of making migration easier for Kibana teams. We will need to remove those tokens again at some point as they are not be used in Borealis.

euiColorVisBehindText0
euiColorVisBehindText1
euiColorVisBehindText2
euiColorVisBehindText3
euiColorVisBehindText4
euiColorVisBehindText5
euiColorVisBehindText6
euiColorVisBehindText7
euiColorVisBehindText8
euiColorVisBehindText9

QA

These tokens are not used anywhere. Make sure the values make sense:

  • Amsterdam - uses values returned from euiPaletteColorBlindBehindText()

  • Borealis maps to default vis colors

  • CI passes

@mgadewoll mgadewoll force-pushed the eui-theme/borealis-behind-text-tokens branch from 755606d to 7528314 Compare December 19, 2024 19:19
@mgadewoll mgadewoll marked this pull request as ready for review December 19, 2024 19:45
@mgadewoll mgadewoll requested a review from a team as a code owner December 19, 2024 19:45
@mgadewoll
Copy link
Contributor Author

ℹ️ FYI I realized we have a breaking test due to the new year. I added the fix here on main: #8258

I'll add the fix to this PR to be able to add the changes, but I will wait until the actual fix PR is reviewed and merged to rebase Borealis.

@mgadewoll mgadewoll force-pushed the eui-theme/borealis-behind-text-tokens branch from 67971c8 to e1109c1 Compare January 7, 2025 09:50
@mgadewoll
Copy link
Contributor Author

ℹ️ FYI I realized we have a breaking test due to the new year. I added the fix here on main: #8258

I'll add the fix to this PR to be able to add the changes, but I will wait until the actual fix PR is reviewed and merged to rebase Borealis.

ℹ️ I rebased this branch with the updated Borealis feature branch that includes the test pipeline fix.

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 7c21c6e into elastic:eui-theme/borealis Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants