-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/8201 deprecate json tokens #8246
Open
weronikaolejniczak
wants to merge
1
commit into
elastic:main
Choose a base branch
from
weronikaolejniczak:chore/8201-deprecate-json-tokens
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/8201 deprecate json tokens #8246
weronikaolejniczak
wants to merge
1
commit into
elastic:main
from
weronikaolejniczak:chore/8201-deprecate-json-tokens
+4,660
−973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acstll
reviewed
Dec 23, 2024
weronikaolejniczak
force-pushed
the
chore/8201-deprecate-json-tokens
branch
from
December 29, 2024 18:44
04461a6
to
5cd5dd5
Compare
weronikaolejniczak
force-pushed
the
chore/8201-deprecate-json-tokens
branch
from
January 7, 2025 10:05
5cd5dd5
to
6a751f9
Compare
weronikaolejniczak
force-pushed
the
chore/8201-deprecate-json-tokens
branch
from
January 8, 2025 10:56
6a751f9
to
b8d7a96
Compare
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added a new rule to our ESLint plugin,
no-restricted-eui-imports
, that won't conflict with the inbuiltno-restricted-imports
rule and will allow us to define several error levels at once. I.e. we want some imports to be marked as warning and not an error, as it's done in Kibana.Context:
The JSON token imports in
@kbn/eslint/module_migration
need to be removed as well:https://github.com/elastic/kibana/blob/212b1926743ca5821992c2877d9c68f621e1875e/packages/kbn-eslint-config/.eslintrc.js#L131-L140
QA
yarn workspace @elastic/eslint-plugin-eui pack
"@elastic/eslint-plugin-eui": "file:path/to/the/package.tgz"
yarn
and bootstrap:yarn kbn bootstrap --no-validate
Unit tests:
yarn workspace @elastic/eslint-plugin-eui test