-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 7561/emotion memoize all generated styles eui tool tip+euicon tip #8240
Open
rebeca1012
wants to merge
10
commits into
elastic:main
Choose a base branch
from
USB-CI3715:issue-7561/emotion-memoize-all-generated-styles-EuiToolTip+EuiconTip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue 7561/emotion memoize all generated styles eui tool tip+euicon tip #8240
rebeca1012
wants to merge
10
commits into
elastic:main
from
USB-CI3715:issue-7561/emotion-memoize-all-generated-styles-EuiToolTip+EuiconTip
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tip-arrow-component [EuiToolTip] Memoized tool_tip_arrow component
…Tip+EuiconTip' of github.com:USB-CI3715/eui into issue-7561/emotion-memoize-all-generated-styles-EuiToolTip+EuiconTip necesario to merge with main
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Memoize Tooltip and Popover components to prevent unnecessary re-renders (Issue #7561)
Detailed Changes
tool_tip_arrow.tsx
Used useEuiMemoizedStyles to memoize the Tooltip component.
_popover_arrow.tsx
Used useEuiMemoizedStyles to memoize _popover_arrow.tsx
popover_footer.tsx
Used useEuiMemoizedStyles to memoize popover_footer.tsx
popover_title.tsx
Used useEuiMemoizedStyles to memoize popover_title.tsx
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@default
if default values are missing) and playground toggles