[EUI+] Reorganize Forms category #8184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
documentation
- Remove top level link/doc and add more sublevel items - give described form group its own page - move compressed forms to this section - remove "in a popover" example from form rows - compressed forms already have this example and explicitly state non-compressed forms should not be used in popovers - remove guideline CTA to its own page??
I gave up on git history, sorry :|||
cee-chen
force-pushed
the
website/reorg-4
branch
from
4cab393 to
46c82bd
Compare
12 tasks
- was previously at the top of a single page with basic controls, will need to spread it out a bit more now - there are more components that can take EuiFormRow (and some that can't), we probably need to audit which at some point. this is not meant to be a perfect solution
- they fit under the general layout guideline text, so might as well move them here?
+ add a demo for nativate invalidation checking
+ some copy/link updates
+ updates etc
cee-chen
changed the title
+ remove various callouts/links to it - in theory now that the components are grouped together, it should be easy to decide which to use - (opinionated, feel free to revert) remove images of various components, not sure how useful it is on the actual docs site
…o its own section + move EuiFormFieldset to the label section (feels like that's where it makes more sense)
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#8163
I was crunched for time, so sadly the git commit history on this PR is something of a tragedy. Apologies! Feel free to chop up/take and use this PR for whatever you want. I categorized the various form controls into sections based primarily on usage type:
Overall sections:
Individual subcategories:
Selection components overview
The biggest thing I really wanted to add to this PR (other than shuffling pages around) was to convert #7049 into an actual page on our docs site instead of needing a separate wiki for it:
And I think this PR succeeds fairly well at that! 🤞 (although there are some TODO comments in the mdx file that I did not have time to improve on)
QA
Formscategory of component docs: https://eui.elastic.co/pr_8184/new-docs/docs/forms/layouts/guidelines/General checklist
N/A, docs changes only