Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix EuiFormControlLayoutDelimited examples with broken input styles #7901

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jul 22, 2024

Summary

https://eui.elastic.co/#/forms/form-controls#form-control-layout-delimited was showing broken styling on raw <input type="number">s due to changes in Emotion conversions. Switching these to <EuiFieldNumber />s fixes the styling.

QA

General checklist

N/A, docs only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Jul 22, 2024
@cee-chen cee-chen marked this pull request as ready for review July 22, 2024 16:38
@cee-chen cee-chen requested a review from a team as a code owner July 22, 2024 16:38
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ Looks as expected now!

@cee-chen cee-chen merged commit 3bd418e into elastic:main Jul 23, 2024
10 of 11 checks passed
@cee-chen cee-chen deleted the docs/form-controls-delimited branch July 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants