feat: add code transformer to <Demo> component
#7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapper so that EuiDataGrid and other components look correct
💚 Build Succeeded
|
mgadewoll
approved these changes
Jul 19, 2024
| } | ||
|
|
||
| // If the demo is more than just JSX wrap in an immediately invoked function expression | ||
| return `(() => { ${code} })()`; |
| const COMPONENT_ONLY_REGEX = /^\(?</; | ||
|
|
||
| /** | ||
| * Transforms input JS/TS source code to a react-live compatible syntax. |
There was a problem hiding this comment.
Thanks for the great description, that's really helpful for understanding! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #7866.
This adds a custom code transformer to our
<Demo>component that makes the existing component examples work withreact-live. The major factor was thatreact-liveonly supports code that's just a JSX component or render function declaration. There's no way to define variables outside of the render function or have import/export statements.The new code transformer removes any import statements because all externals should always come from the
scope, and wraps the source code in an IIFE to support defining variables and functions outside of the render function as we often do in our examples.QA