Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New site] Content section #7890

Merged
merged 13 commits into from
Jul 26, 2024

Conversation

florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Jul 18, 2024

Summary

This PR is a rework of the Writing section for the new EUI documentation site.
This is a re-do of #7710 that was targeting an old feature branch, with a few more changes made to the content.

@szabosteve
Copy link
Contributor

@florent-leborgne @nastasha-solomon @mdbirnstiehl I gave it a try and simplified the tone section as we discussed in our last meeting. I removed the "Friendly" tone as it overlaps with "Stimulating". I also merged "Empathetic" and "Supportive" as they are also similar. In this case, I kept "Empathetic" and broadened its scope in the description. Please let me know if you want to change anything.

Copy link
Contributor Author

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szabosteve Thanks for your work on the Tone page. I think the way you reduced it is perfect. I only left a few minor comments

@szabosteve szabosteve requested a review from mdbirnstiehl July 26, 2024 12:00
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version LGTM.

@florent-leborgne florent-leborgne marked this pull request as ready for review July 26, 2024 12:55
@florent-leborgne florent-leborgne requested a review from a team as a code owner July 26, 2024 12:55
type: 'docSidebar',
sidebarId: 'contentSidebar',
position: 'left',
label: 'Content',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there are a few concerns about renaming this section from Writing to Content. While Writing is fine, Content is the way this type of... content is called in most design systems today. That is mainly due to the fact that these practices are known as Content Design. Happy to revisit if we think Writing is still the best approach to name this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy calling it Content :)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @florent-leborgne

@florent-leborgne florent-leborgne changed the title [WIP - New site] Content section [New site] Content section Jul 26, 2024
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for working on this!

@tkajtoch tkajtoch merged commit f0c1fb9 into elastic:main Jul 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries New EUI site skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants