-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New site] Content section #7890
[New site] Content section #7890
Conversation
@florent-leborgne @nastasha-solomon @mdbirnstiehl I gave it a try and simplified the tone section as we discussed in our last meeting. I removed the "Friendly" tone as it overlaps with "Stimulating". I also merged "Empathetic" and "Supportive" as they are also similar. In this case, I kept "Empathetic" and broadened its scope in the description. Please let me know if you want to change anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szabosteve Thanks for your work on the Tone page. I think the way you reduced it is perfect. I only left a few minor comments
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version LGTM.
type: 'docSidebar', | ||
sidebarId: 'contentSidebar', | ||
position: 'left', | ||
label: 'Content', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there are a few concerns about renaming this section from Writing to Content. While Writing is fine, Content is the way this type of... content is called in most design systems today. That is mainly due to the fact that these practices are known as Content Design. Happy to revisit if we think Writing is still the best approach to name this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy calling it Content
:)
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for working on this!
Summary
This PR is a rework of the Writing section for the new EUI documentation site.
This is a re-do of #7710 that was targeting an old feature branch, with a few more changes made to the content.