[EUI+] Implement site header design changes #7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui+/7737-site-header-design-changes-2
branch
from
6f54ae7 to
b4bacb3
Compare
- adds custom component to handle navbar items
- uses EUI components in the ejected component and updates styles
- adds smaller cleanup and refactors based on newly ejected components
mgadewoll
force-pushed
the
eui+/7737-site-header-design-changes-2
branch
from
42dfd63 to
a25c510
Compare
|
The code looks great! I noticed the header isn't sticky anymore - could you please fix that? |
- ejects Navbar/Layout component to apply styles instead of adding wrapper as the wrapper breaks the sticky behavior
Ah thanks for the catch! It broke because I used a wrapper around the Navbar to apply the styles to prevent having to eject, but that breaks the sticky behavior. |
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes elastic/eui-private#110
Important
This PR only applies styles changes as far as it was possible without breaking the search plugin implementation.Ejecting components that change the context would result in a non-functioning search, hence this PR only applies changes from the outside but can't change overall DOM on global levels.
This results in the site header right items not matching the order proposed in the design.
This issue was resolved with this fix PR.
Screenshots
QA