Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUI+] Implement Breadcrumbs design changes #7885

Merged
merged 4 commits into from
Jul 16, 2024
Merged

[EUI+] Implement Breadcrumbs design changes #7885

merged 4 commits into from
Jul 16, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Jul 12, 2024 •
edited by tkajtoch
Loading

Summary

closes elastic/eui-private#111

Changes

  • ejects more Docusaurus components to ensure nested ejected components work (they need to shared the same context)
    • this is a bit of a snowball because the higher up we need to eject the more we need to eject with it if the components use provider hooks
  • adds ejected breadcrumbs components and updates styles to align with current initial design

Screenshots

Screenshot 2024-07-12 at 14 06 35

Screenshot 2024-07-12 at 14 06 30

Screenshot 2024-07-12 at 14 27 04

QA

mgadewoll added 2 commits July 12, 2024 14:00
@mgadewoll
refactor: eject more required components
afd730d 
- ensures correct provider context for sub components
@mgadewoll
feat: update Breadcrumbs styles
3803294
@mgadewoll mgadewoll changed the title [EUI+]/ Implement Breadcrumbs design changes [EUI+] Implement Breadcrumbs design changes Jul 12, 2024
@mgadewoll mgadewoll marked this pull request as ready for review July 12, 2024 13:17
@mgadewoll mgadewoll requested a review from a team as a code owner July 12, 2024 13:17
tkajtoch
tkajtoch approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look and work great!

@mgadewoll mgadewoll enabled auto-merge (squash) July 16, 2024 07:38
@mgadewoll mgadewoll merged commit c1437b7 into elastic:main Jul 16, 2024
5 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkajtoch tkajtoch tkajtoch approved these changes

Assignees
No one assigned
Labels
EUI Plus New EUI site skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgadewoll @elasticmachine @tkajtoch