[Emotion] Convert EuiSaturation and EuiHue #7857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Sass variables - I don't see a reason to keep them as they're not being reused anywhere and don't need to be overridden
- simplify negative margins to transform translates
+ standardize mouse vs keyboard focus indicators + delete Sass files
- move classes/styles to top of file - convert inline position styles to logical properties - memoize various functions - fix IDs potentially being invalid if no `id` prop is passed
- Remove now-unnecessary IE/moz resets - Simplify focus/visible styles, overrides, etc - remove unnecessary z-index and euiCustomControl mixin, replace `top` offset with negative margin
:| legitimately not sure what on earth is going on with the indicator styles, I think the nested template literal is throwing stylelint for a loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
I recommend code reviewing by commit for this PR!
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles