[Fix] Ensure Storybook loads EUI fonts #7856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
documentation
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
cee-chen
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently EUI Storybook does not actually load the EUI fonts. 🤯
We were seeing either the system installed
Inter/Roboto Monofont locally or a fallback font (Helvetica/Menlo).The images generated by VRT were also using different fonts and need updating 🙈
Screen.Recording.2024-06-26.at.17.10.55.mov
Screen.Recording.2024-06-26.at.17.36.38.mov
This PR ensures that the fonts are actually loaded for the Storybook preview.
How to reproduce?
Open production Storybook (e.g. for
EuiButton) in an incocgnito window of your browser and override thefont-familyto'Inter'and see that the font is not actually available.QA