[tech debt] Convert remaining table Enzyme tests to RTL #7836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete meaningless `executeQueryOptions` snapshot test, it's not asserting anything meaningful and there's a better test down below - DRY out cell text assertion to a fn util
cee-chen
added
testing
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
mgadewoll
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Grabbing various Enzyme tech debt tests as tech debt for fix-it-Fridays.
See git commit messages for slightly more detailed reasoning behind certain changes
QA
General checklist