[tech debt] Convert remaining Enzyme tests in src/services to RTL
#7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ prefer renderHook over mock component
+ prefer renderHook over mock component for arg testing
- mostly just rerender/unmount API changes
cee-chen
added
testing
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
mgadewoll
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
🎉 Nice update! Looks good to me 👍
🗒️ Note to myself to rebase and check this also on the jest upgrade PR. I don't expect any issues from this though 🙂
All clear, as expected there were no issues on jest 29. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should be pretty straightforward! Was spurred into grabbing this as a small mental break when Tomasz recently mentioned our Enzyme tech debt 👀
QA
General checklist