Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update release script for yarn berry #7826

Merged
merged 2 commits into from
Jun 10, 2024
Merged

build: update release script for yarn berry #7826

merged 2 commits into from
Jun 10, 2024

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Jun 10, 2024 •
edited by cee-chen
Loading

Summary

Yarn Berry doesn't commit or tag created versions. This updates our release script to commit and tag the updated package.json the same way Yarn Classic did.

QA

  • Confirm the updated script executes commands that make sense. Test each command locally if needed

@tkajtoch tkajtoch self-assigned this Jun 10, 2024
@tkajtoch tkajtoch requested a review from a team as a code owner June 10, 2024 19:11
cee-chen
cee-chen approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection!!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @tkajtoch

@tkajtoch tkajtoch merged commit b752e50 into elastic:main Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees

@tkajtoch tkajtoch

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkajtoch @kibanamachine @elasticmachine @cee-chen