Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VRT step to PR template checklist #7825

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jun 10, 2024

Summary

See below. Now that we have Loki working locally, let's go ahead and add a step to check/update VRT screenshots to our PR template

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • Updated the Figma library counterpart

@cee-chen cee-chen marked this pull request as ready for review June 10, 2024 18:47
@cee-chen cee-chen requested a review from a team as a code owner June 10, 2024 18:47
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! 🎉

@cee-chen cee-chen merged commit 4439019 into elastic:main Jun 11, 2024
9 checks passed
@cee-chen cee-chen deleted the gh-vrt-template branch June 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants