Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VRT] update reference images #7816

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Jun 6, 2024

Summary

This PR updates VRT references images that were outdated for different reasons mainly because we currently don't yet have an automated process of checking them which leads to images not always being updated after changes.

Additionally it fixes the selected date for the EuiDatePicker story to prevent the VRT images from being outdated due to the current date changing.

It also adds a small cleanup on the EuiBasicTable story for selection prop not being passed along.

QA

The image changes are based on code in main, the changes should be expected.

Updated stories:

mgadewoll added 3 commits June 6, 2024 18:09
- this will prevent the datepicker to update the month based on the current date which otherwise creates VRT image differences
@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Jun 6, 2024
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mgadewoll mgadewoll marked this pull request as ready for review June 6, 2024 16:46
@mgadewoll mgadewoll requested a review from a team as a code owner June 6, 2024 16:46
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping these up to date manually Lene! Definitely hoping we can set up automation at some point

@mgadewoll mgadewoll merged commit 317efdb into elastic:main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants