[VRT] update reference images #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this will prevent the datepicker to update the month based on the current date which otherwise creates VRT image differences
mgadewoll
added
documentation
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
cee-chen
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates VRT references images that were outdated for different reasons mainly because we currently don't yet have an automated process of checking them which leads to images not always being updated after changes.
Additionally it fixes the selected date for the
EuiDatePickerstory to prevent the VRT images from being outdated due to the current date changing.It also adds a small cleanup on the
EuiBasicTablestory forselectionprop not being passed along.QA
The image changes are based on code in
main, the changes should be expected.Updated stories: