Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add loki step to CI #7747

Closed
wants to merge 10 commits into from
Closed

Conversation

tkajtoch
Copy link
Member

Summary

Resolves #7617.

This PR adds a new buildkite step to run Loki in CI for open pull requests.

QA

QA needs to be done manually after merging this PR. Please make sure the script and configuration look valid.

@tkajtoch tkajtoch self-assigned this May 13, 2024
@tkajtoch tkajtoch requested a review from a team as a code owner May 13, 2024 11:07
echo "+++ Running visual regression tests on pull request #${BUILDKITE_PULL_REQUEST}"
echo "https://github.com/elastic/eui/pull/${BUILDKITE_PULL_REQUEST}"
storybook_url="https://eui.elastic.co/pr_${BUILDKITE_PULL_REQUEST}/storybook"
elif [[ "${BUILDKITE_BRANCH}" == "main" ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically unused as of now, but will be in the release pipeline when this script is tested

@tkajtoch tkajtoch marked this pull request as draft May 13, 2024 12:28
@tkajtoch tkajtoch force-pushed the build/loki-ci branch 5 times, most recently from c42807c to 34769f5 Compare May 13, 2024 17:58
@tkajtoch
Copy link
Member Author

Will be unblocked and ready for review when https://github.com/elastic/ci-agent-images/pull/691 is merged

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 28, 2024

💔 Build Failed

Failed CI Steps

History

cc @tkajtoch

Copy link

👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

Copy link

github-actions bot commented Sep 3, 2024

❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Loki to test open PRs in CI
3 participants