[Storybook] Add stories for more components (letters R-S) - Part 4 #7733
Conversation
mgadewoll
added
documentation
There was a problem hiding this comment.
[just me thinking out loud] I sometimes wonder how much value consumers get from us exporting subcomponents like this, vs just the higher level components 🤔
There was a problem hiding this comment.
It can have value to understand what's available, how it works etc. Or even to maybe reuse some components in other contexts even if unexpected? 🤔
- which is its own separate style
cee-chen
force-pushed
the
storybook/7482-stories-r-s-part-4
branch
from
db10dd3 to
6b8eb75
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
| @@ -12,7 +12,7 @@ import { hideStorybookControls } from '../../../.storybook/utils'; | |||
| import { EuiStepNumber, EuiStepNumberProps } from './step_number'; | |||
|
|
|||
| const meta: Meta<EuiStepNumberProps> = { | |||
| title: 'Navigation/EuiSteps/EuiStepNumber', | |||
| title: 'Navigation/EuiSteps/Subcomponents/EuiStepNumber', | |||
There was a problem hiding this comment.
Hmm, if I remember correctly, we had a discussion some time ago about nesting conventions and agreed that we nest subcomponents under the components based on component name and that we wouldn't add other folders as that might be confusing? (conversation)
So the idea would be that EuiStepNumber is a subcomponent of EuiSteps (or even EuiStep) so it's nested under those.
Next to other components the naming Subcomponents now would mean there is a component called Subcomponents if we go by how we organized components so far 😅
Summary
closes #7482
This PR adds more stories for components with the letter S:
Additionally adds base VRT reference images based on the added stories.
QA