Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VRT] Add reference images for recently added stories #7730

Merged
merged 4 commits into from
May 8, 2024

Conversation

mgadewoll
Copy link
Contributor

Summary

This PR adds VRT base references images for recently added stories that did not have VRT images set up yet.

Additionally it ensures that data used in the EuiDataGrid story is stable by using faker.seed() to prevent flagged changes on every run.

QA

  • overview the added reference images generally if anything unexpected stands out otherwise this PR is relatively straight forward

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mgadewoll mgadewoll marked this pull request as ready for review May 3, 2024 11:33
@mgadewoll mgadewoll requested a review from a team as a code owner May 3, 2024 11:33
@mgadewoll mgadewoll changed the title [VRT]: Add reference images for recently added stories [VRT] Add reference images for recently added stories May 3, 2024
@cee-chen cee-chen requested a review from tkajtoch May 3, 2024 16:15
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@mgadewoll mgadewoll merged commit 3cee5c1 into elastic:main May 8, 2024
9 checks passed
@mgadewoll mgadewoll deleted the storybook/missing-vrt-references branch May 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants