Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Add stories for more components (letters R-S) - Part 3 #7729

Merged
merged 3 commits into from
May 8, 2024
Merged

[Storybook] Add stories for more components (letters R-S) - Part 3 #7729

merged 3 commits into from
May 8, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented May 3, 2024 •
edited by cee-chen
Loading

Summary

This PR adds more stories for components with the letter S:

  • EuiSkeletonLoading
  • EuiSkeletonCircle
  • EuiSkeletonRectangle
  • EuiSkeletonText
  • EuiSkeletonTitle

Additionally adds base VRT reference images based on the added stories.

QA

  • Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels May 3, 2024
@mgadewoll mgadewoll marked this pull request as ready for review May 3, 2024 10:28
@mgadewoll mgadewoll requested a review from a team as a code owner May 3, 2024 10:28
cee-chen
cee-chen approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Gotta love a nice and straightforward set of stories! I'm still so thrilled that these skeleton components came from a super random and awesome community contribution!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 6964e7b into elastic:main May 8, 2024
5 checks passed
@mgadewoll mgadewoll deleted the storybook/7482-stories-r-s-part-3 branch May 8, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgadewoll @kibanamachine @elasticmachine @cee-chen