Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion][perf] Remaining unmemoized button styles #7634

Merged
merged 2 commits into from
Apr 1, 2024
Merged

[Emotion][perf] Remaining unmemoized button styles #7634

merged 2 commits into from
Apr 1, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Mar 29, 2024 •
edited
Loading

Summary

I missed these in #7541!

QA

  • EuiButton loading spinner + icons look the same as before
  • EuiButtonGroup compressed focus colors work as before

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked in mobile
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA - N/A
  • Code quality checklist - N/A
  • Release checklist - N/A, skipping changelog due to this being perf tech debt that shouldn't impact consumers
  • Designer checklist - N/A

cee-chen added 2 commits March 29, 2024 09:24
@cee-chen
[EuiButtonDisplayContent] Memoize styles + rendered icon
8ee9c42
@cee-chen
[EuiButtonGroup] Memoize styles
28c34e4 
- requires creating a new map for compressed focus colors

- move uncompressed focus color to base styles, makes more sense there anyway
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen cee-chen marked this pull request as ready for review March 29, 2024 17:29
@cee-chen cee-chen requested a review from a team as a code owner March 29, 2024 17:29
@cee-chen cee-chen mentioned this pull request Mar 29, 2024
Open
22 tasks
JasonStoltz
JasonStoltz approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@JasonStoltz JasonStoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I think the refactor for uncompressed button styles makes sense, and all of the tests are passing.

@cee-chen cee-chen merged commit 49d13e4 into elastic:main Apr 1, 2024
16 of 17 checks passed
@cee-chen cee-chen deleted the emotion/memoization-buttons-remaining branch April 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonStoltz JasonStoltz JasonStoltz approved these changes

Assignees
No one assigned
Labels
emotion performance skip-changelog tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cee-chen @kibanamachine @elasticmachine @JasonStoltz