Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node to v20.11.1 #7539

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Upgrade Node to v20.11.1 #7539

merged 2 commits into from
Feb 20, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Feb 20, 2024 •
edited
Loading

QA

General checklist

  • CI passes

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen cee-chen marked this pull request as ready for review February 20, 2024 22:20
@cee-chen cee-chen requested a review from a team as a code owner February 20, 2024 22:20
1Copenut
1Copenut approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! I kind of forgot I moved the single Docker image declaration into pre_command.sh so had to grep for it :)

@cee-chen
Copy link
Contributor Author

I know that feeling of past-you being smarter than present-you 🤣

@cee-chen cee-chen merged commit 8cc0fec into elastic:main Feb 20, 2024
12 of 13 checks passed
@cee-chen cee-chen deleted the node-upgrade branch February 20, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

Assignees
No one assigned
Labels
skip-changelog tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cee-chen @kibanamachine @elasticmachine @1Copenut