[DOCS] Added a11y guidance for EuiTooltip and EuiPopover
#7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a11y guidance to EuiTooltip. * Added a11y guidance to EuiPopover.
1Copenut
added
documentation
1Copenut
changed the title
EuiTooltip and EuiPopover
1Copenut
changed the title
EuiTooltip and EuiPopoverEuiTooltip and EuiPopover
|
Preview staging links for this PR:
|
💚 Build Succeeded
cc @1Copenut |
JasonStoltz
approved these changes
Feb 14, 2024
cee-chen
reviewed
Feb 14, 2024
|
|
||
| <EuiCallOut | ||
| iconType="accessibility" | ||
| color="warning" |
There was a problem hiding this comment.
I really like how you moved the popover intro up here!
One note: We've historically used the blue/informational color for accessibility callouts in the past (example here). I'm not sure how we want to strike the balance of friendliness vs importance, but I think we should consider noting all our callouts around accessibility and ensuring we have some sort of consistent pattern in place and documented for it.
There was a problem hiding this comment.
I wondered about that, and I'm glad you brought it up @cee-chen. I'm happy to take another swing at this to modify the a11y callouts to blue and use that as a general guideline for future callouts.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated documentation for a11y considerations in the
EuiTooltipandEuiPopovercomponents. Screenshots attached at the bottom.QA
Remove or strikethrough items that do not apply to your PR.
General checklist