Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node version to 20.11.0 #7511

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Upgrade Node version to 20.11.0 #7511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db56b97
Upgrade all node version references
cee-chen Feb 5, 2024
40312c3
Update docker image
cee-chen Feb 5, 2024
0f1ca37
Fix failing Cypress spec
cee-chen Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/scripts/lifecycle/pre_command.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export GCE_ACCOUNT
GITHUB_TOKEN=$(retry 5 vault read -field=github_token $GITHUB_ACCOUNT)
export GITHUB_TOKEN

DOCKER_BASE_IMAGE=docker.elastic.co/eui/ci:6.1
DOCKER_BASE_IMAGE=docker.elastic.co/eui/ci:6.2
export DOCKER_BASE_IMAGE

GCE_IMAGE=google/cloud-sdk:slim
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.10.0
20.11.0
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"main": "lib",
"module": "es",
"types": "eui.d.ts",
"docker_image": "20.10.0",
"docker_image": "20.11.0",
"engines": {
"node": "16.x || 18.x || >=20.x"
},
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://github.com/zenato/docker-puppeteer/blob/master/Dockerfile

# >=12.0 required (for cypress). v18 is LTS.
FROM --platform=linux/amd64 node:20.10.0-slim
FROM --platform=linux/amd64 node:20.11.0-slim

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand Down
2 changes: 1 addition & 1 deletion src/components/selectable/selectable.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ describe('EuiSelectable', () => {

cy.get('[data-test-subj="truncatedText"]')
.first()
.should('have.text', 'Lorem ipsum …iscing elit.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a coincidence this test failed on this PR, or is there something to it? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a coincidence, it's failing for me on local too (and has been for a few weeks). I'm pretty sure it's to do with an Electron or browser version upgrade that's changing scrollbar width and causing the change.

.should('have.text', 'Lorem ipsum …piscing elit.');
});

it('correctly accounts for the keyboard focus badge', () => {
Expand Down
Loading