Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix validateDOMNesting warning #7508

Merged
merged 10 commits into from
Feb 5, 2024
Merged

test: fix validateDOMNesting warning #7508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
50ae494
test(EuiTableFooterCell): fix validateDOMNesting warning
Juneezee Feb 4, 2024
b8933e4
test(EuiTableFooter): fix validateDOMNesting warning
Juneezee Feb 4, 2024
00896ae
test(EuiTableHeader): fix validateDOMNesting warning
Juneezee Feb 4, 2024
5066e5d
test(EuiTableHeaderCellCheckbox): fix validateDOMNesting warning
Juneezee Feb 4, 2024
bade180
test(EuiTableHeaderCell): fix validateDOMNesting warning
Juneezee Feb 4, 2024
8410596
test(EuiTableRowCellCheckbox): fix validateDOMNesting warning
Juneezee Feb 4, 2024
8ff1fca
test(EuiTableRowCell): fix validateDOMNesting warning
Juneezee Feb 4, 2024
ac3ddd6
test(EuiTableRow): fix validateDOMNesting warning
Juneezee Feb 4, 2024
58c4644
[PR feedback] arrow syntax as opposed to function syntax
cee-chen Feb 5, 2024
616a5b1
Restore `validateDOMNesting` to errors
cee-chen Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions scripts/jest/setup/throw_on_console_error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,5 @@ console.error = (message, ...rest) => {
return;
}

// Print React validateDOMNesting warning as a console.warn instead
// of throwing an error.
// TODO: Remove when edge-case DOM nesting is fixed in all components
if (
typeof message === 'string' &&
message.startsWith(
'Warning: validateDOMNesting(...): %s cannot appear as a child of <%s>'
)
) {
console.warn(message, ...rest);
return;
}

throw new Error(format(message, ...rest));
};
8 changes: 5 additions & 3 deletions src/components/table/__snapshots__/table_footer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`EuiTableFooter is rendered 1`] = `
<div>
<table>
<tfoot
aria-label="aria-label"
class="testClass1 testClass2 emotion-euiTestCss"
data-test-subj="test subject string"
>
<tr>
children
<td>
children
</td>
</tr>
</tfoot>
</div>
</table>
`;
256 changes: 152 additions & 104 deletions src/components/table/__snapshots__/table_footer_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,129 +1,177 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`EuiTableFooterCell align defaults to left 1`] = `
<td
class="euiTableFooterCell"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
/>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
/>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell align renders center when specified 1`] = `
<td
class="euiTableFooterCell"
>
<div
class="euiTableCellContent euiTableCellContent--alignCenter"
>
<span
class="euiTableCellContent__text"
/>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
>
<div
class="euiTableCellContent euiTableCellContent--alignCenter"
>
<span
class="euiTableCellContent__text"
/>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell align renders right when specified 1`] = `
<td
class="euiTableFooterCell"
>
<div
class="euiTableCellContent euiTableCellContent--alignRight"
>
<span
class="euiTableCellContent__text"
/>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
>
<div
class="euiTableCellContent euiTableCellContent--alignRight"
>
<span
class="euiTableCellContent__text"
/>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell is rendered 1`] = `
<td
aria-label="aria-label"
class="euiTableFooterCell testClass1 testClass2 emotion-euiTestCss"
data-test-subj="test subject string"
>
<div
class="euiTableCellContent testClass1 testClass2 emotion-euiTestCss"
>
<span
class="euiTableCellContent__text"
>
children
</span>
</div>
</td>
<table>
<tfoot>
<tr>
<td
aria-label="aria-label"
class="euiTableFooterCell testClass1 testClass2 emotion-euiTestCss"
data-test-subj="test subject string"
>
<div
class="euiTableCellContent testClass1 testClass2 emotion-euiTestCss"
>
<span
class="euiTableCellContent__text"
>
children
</span>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell width and style accepts style attribute 1`] = `
<td
class="euiTableFooterCell"
style="width: 20%;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
style="width: 20%;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell width and style accepts width attribute 1`] = `
<td
class="euiTableFooterCell"
style="width: 10%;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
style="width: 10%;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell width and style accepts width attribute as number 1`] = `
<td
class="euiTableFooterCell"
style="width: 100px;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
style="width: 100px;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
</tr>
</tfoot>
</table>
`;

exports[`EuiTableFooterCell width and style resolves style and width attribute 1`] = `
<td
class="euiTableFooterCell"
style="width: 10%;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
<table>
<tfoot>
<tr>
<td
class="euiTableFooterCell"
style="width: 10%;"
>
<div
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
>
Test
</span>
</div>
</td>
</tr>
</tfoot>
</table>
`;
40 changes: 22 additions & 18 deletions src/components/table/__snapshots__/table_header.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,29 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`EuiTableHeader is rendered 1`] = `
<thead
aria-label="aria-label"
class="testClass1 testClass2 emotion-euiTestCss"
data-test-subj="test subject string"
>
<tr>
<td>
children
</td>
</tr>
</thead>
<table>
<thead
aria-label="aria-label"
class="testClass1 testClass2 emotion-euiTestCss"
data-test-subj="test subject string"
>
<tr>
<td>
children
</td>
</tr>
</thead>
</table>
`;

exports[`EuiTableHeader is rendered without <tr> 1`] = `
<thead>
<tr>
<td>
children
</td>
</tr>
</thead>
<table>
<thead>
<tr>
<td>
children
</td>
</tr>
</thead>
</table>
`;
Loading
Loading