[CHORE] Bump nvmrc and Docker to use Node v20.10.0 #7426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Dec 19, 2023
Comment on lines
-19
to
-20
| "test-docker": "node ./scripts/test-docker.js", | ||
| "test-a11y-docker": "node ./scripts/test-a11y-docker.js", |
There was a problem hiding this comment.
This doesn't seem like it should be part of the node upgrade
There was a problem hiding this comment.
That's valid. The scripts were removed prior, but I can move the lines back into package.json and remove them as a separate PR.
There was a problem hiding this comment.
ahh I hadn't realized! I'm fine removing them in this PR as long as we point it out / it's a deliberate choice; just at first glance I thought it was a mistake
cee-chen
reviewed
Dec 19, 2023
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR bumps our Docker Node image and daily driver Node to version
20.10.0. PR closes #7424.QA
nvm install 20.10.0nvm alias default 20.10.0yarnyarn lintyarn test-unityarn test-cypressyarn storybooknvm install 20.10.0nvm alias default 20.10.0yarnyarn lintyarn test-unityarn test-cypressyarn storybook