-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a part of existing docs content to the new docs site #7417
Conversation
22afd1f
to
0a55e29
Compare
@tkajtoch What should I expect to see at this point? It looks like the page content is available, but without embedded code examples. It also looks like embedded links are not working yet. Should I expect them to be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment about the missing link. Will review individual pages when build is passing.
website/src/pages/index.tsx
Outdated
<div className={styles.buttons}> | ||
<Link | ||
className="button button--secondary button--lg" | ||
to="/docs/intro"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line here is the reason your build is failing @tkajtoch. I pulled the branch and started it locally, was able to recreate the missing page message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 99795b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the fix works as expected and all pages render properly. 🚀
c76360c
to
5ba64af
Compare
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @tkajtoch |
@JasonStoltz Embedded code samples will be added in a separate PR. Links to other component docs will be updated when all docs are converted to MDX. |
Summary
This PR adds MDX documentation content of the following components to the new docs site:
This work is a part of #7404. The new docs added in this PR are missing component previews and examples that will be added separately as part of #7405.
QA