-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add guidance for EuiTabs
around higher-order navigation
#7410
Conversation
* Adding a Guidance tab to EuiTabs docs * Providing UX guidance for hash routes and higher-level navigation
👀 ❓ |
Screenshots added this time. Got distracted and forgot to attach them. |
I'm slightly confused about the guidance here. Is this correct? Does it make the guidance clearer? Do Do Don't Don't |
Thanks @JasonStoltz. I took another pass using your feedback and adding a couple of insights. |
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
Summary
We made some decisions about the
EuiBreadcrumbs
component in a design discussion in before UX Summit. One of the recommended actions was to document best practices for using tabs, based on my comment about tabs updating breadcrumb links.This PR adds a
Guidelines
tab toEuiTabs
and cross-links the new guidance from ourEuiBreadcrumbs
page. Screenshots attached below QA criteria. PR closes #7367.QA
Remove or strikethrough items that do not apply to your PR.
General checklist