Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better backport and prerelease DX #7390

Merged
merged 8 commits into from
Dec 3, 2023
Merged

Better backport and prerelease DX #7390

merged 8 commits into from
Dec 3, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Nov 30, 2023

Summary

  • Adds scripts specifically for backport and prerelease releases
  • Updates the release script to handle the above special release
  • Adds regex filter to our eui-release-deploy-docs job so we do not deploy the main docs site for backports or release candidates (backports will now be vx.x.x-backport.0 instead of patches)

QA

QA will be done manually in Buildkite. We'll verify the release docs job doesn't run when backport or rc branches are tagged.

@kibanamachine
Copy link

Preview staging links for this PR:

- make step check more readable

- fix totally missing dry run behavior, wasn't previously working in a meaningful way

+ add a `--no-verify` skip for the push step if we've already run tests
- just makes code harder to read, IMO
- remove need for validating the type, and instead have the main release script pass in the expected version name

- we're going to need this for the upcoming backport/prerelease work

+ remove the command for updating the tokens changelog - this really only needs to be called on release, and we've been having some PRs with this run when it doesn't need to be
- since we're baking this behavior into the main release script as-is
@cee-chen cee-chen marked this pull request as ready for review December 3, 2023 05:24
@cee-chen cee-chen requested a review from a team as a code owner December 3, 2023 05:24
@cee-chen cee-chen changed the title [CHORE] Setting regex for Buildkite release job tag filter. Better backport and prerelease DX Dec 3, 2023
@cee-chen cee-chen merged commit 783dfb9 into elastic:main Dec 3, 2023
2 checks passed
cee-chen added a commit that referenced this pull request Dec 3, 2023
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

@cee-chen
Copy link
Contributor

cee-chen commented Dec 4, 2023

Failure does not appear to be related to code in this PR, error message says 'agent lost'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants