[CHORE] Bumping axe-core to v4.8.2. Matches Kibana version. #7370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumping our axe-core ruleset to the current version. This matches Kibana's recent merge to latest.
PR closes #7357.
Note about
EuiAccordionI removed the
EuiLinkinside our accordion under test. The latest version of axe-core is throwing an error about links relying on color to distinguish them from non-clickable text. While valid, it was throwing a false positive for the component under test. I'd rather handle link underlines as their own task in the name of getting this PR merged.QA
QA will be done in Buildkite CI. We will know PR is ready to review when all Cypress a11y tests pass green.