Remove undocumented Random service
#7329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
remove-random
branch
2 times, most recently
from
bac483d to
e7d713c
Compare
- prefer explicitly running each option instead of randomly selecting them per test - randomized testing is not good testing practice
cee-chen
force-pushed
the
remove-random
branch
from
e7d713c to
612908d
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
JasonStoltz
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #4832
While we're no longer working towards removing lodash from EUI as a priority, this is still a nice cleanup item to have because it's one (to three) less piece(s) of code that the EUI team has to maintain and be responsible for for both ourselves and external consumers.
As always, I recommend following along by commit - most
Randomusages were replaced instead withfaker(per the issue recommendation), but a few tests had their random behavior removed insteadQA
EuiSearchBardocs examples work as beforeGeneral checklist
and cypress tests- [ ] A changelog entry exists and is marked appropriately.- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)