Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Loki to test open PRs in CI #7617

Closed
tkajtoch opened this issue Mar 25, 2024 · 3 comments
Closed

Configure Loki to test open PRs in CI #7617

tkajtoch opened this issue Mar 25, 2024 · 3 comments
Assignees
Labels
blocked task A task associated with a larger Meta issue

Comments

@tkajtoch
Copy link
Member

tkajtoch commented Mar 25, 2024

Summary

Loki is a Visual Regression Testing software that integrates with Storybook. We need to run it in CI for every open PR to ensure no unwanted UI changes get merged to main.

Please follow the guide on Loki's website: https://loki.js.org/continuous-integration.html.

Due to the architecture of our current CI pipeline, Loki CI step should depend on the eui-pull-request-deploy-docs step since it depends on Storybook being deployed.

Acceptance Criteria

  • Loki should run as a separate CI step after Storybook is built and deployed
  • loki command should be executed with the --requireReference flag and CI=true environment variable set
  • failed tests should result in a failed step status and blocked PR merge
@tkajtoch tkajtoch added the task A task associated with a larger Meta issue label Mar 28, 2024
@tkajtoch
Copy link
Member Author

The blocking issue has just been merged

@tkajtoch
Copy link
Member Author

Will be unblocked and ready for review when https://github.com/elastic/ci-agent-images/pull/691 is merged

@tkajtoch
Copy link
Member Author

I moved this to on hold since there's a race condition in Loki that seems to happen randomly when running in CI with Storybook 8.

For more context: storybookjs/test-runner#442

@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@cee-chen cee-chen reopened this Oct 14, 2024
@cee-chen cee-chen removed the Stale label Oct 14, 2024
@JasonStoltz JasonStoltz added task A task associated with a larger Meta issue and removed task A task associated with a larger Meta issue labels Jan 8, 2025
@JasonStoltz JasonStoltz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked task A task associated with a larger Meta issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants