Relax href-or-on-click rule to warning

elastic · Jan 4, 2024 · e3e7d5e · e3e7d5e
1 parent e310d71
commit e3e7d5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/eslint-plugin/index.js b/packages/eslint-plugin/index.js
@@ -25,7 +25,7 @@ module.exports = {
     recommended: {
       plugins: ['@elastic/eslint-plugin-eui'],
       rules: {
-        '@elastic/eui/href-or-on-click': 'error',
+        '@elastic/eui/href-or-on-click': 'warn',
       },
     },
   },

diff --git a/packages/eslint-plugin/rules/href_or_on_click.js b/packages/eslint-plugin/rules/href_or_on_click.js
@@ -24,7 +24,7 @@ module.exports = {
         if (hasHref && hasOnClick) {
           context.report(
             node,
-            `<${node.name.name}> accepts either \`href\` or \`onClick\`, not both.`
+            `<${node.name.name}> supplied with both \`href\` and \`onClick\`; is this intentional? (Valid use cases include programmatic navigation via \`onClick\` while preserving "Open in new tab" style functionality via \`href\`.)`
           );
         }
       },