[EuiSelectable] Fix non-virtualized lists causing Jest errors (#7618)

elastic · Mar 25, 2024 · ac3396e · ac3396e
1 parent 08dbb9b
commit ac3396e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelogs/upcoming/7618.md b/changelogs/upcoming/7618.md
@@ -0,0 +1,3 @@
+**Bug fixes**
+
+- Fixed unvirtualized `EuiSelectable`s to not cause Jest/jsdom errors on active option change
diff --git a/src/components/selectable/selectable_list/selectable_list.tsx b/src/components/selectable/selectable_list/selectable_list.tsx
@@ -264,7 +264,9 @@ export class EuiSelectableList<T> extends Component<
           const activeOptionId = `#${makeOptionId(activeOptionIndex)}`;
           const activeOptionEl = this.listBoxRef?.querySelector(activeOptionId);
           if (activeOptionEl) {
-            activeOptionEl.scrollIntoView({ block: 'nearest' });
+            // TODO: we can remove scrollIntoView's conditional chaining once jsdom stubs it
+            // @see https://github.com/jsdom/jsdom/issues/1695
+            activeOptionEl.scrollIntoView?.({ block: 'nearest' });
           }
         }
       }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bug fixes

		- Fixed unvirtualized `EuiSelectable`s to not cause Jest/jsdom errors on active option change