Skip to content

Commit

Permalink
Revert changes to column_sorting tests
Browse files Browse the repository at this point in the history
  • Loading branch information
davismcphee committed Feb 24, 2024
1 parent 5336e36 commit a1a5835
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ exports[`useDataGridColumnSorting columnSorting [React 16] renders a toolbar but
aria-pressed="true"
class="euiButtonGroupButton euiButtonGroupButton-isSelected emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-fill-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-asc"
title="Low-High"
type="button"
>
<span
Expand All @@ -178,6 +179,7 @@ exports[`useDataGridColumnSorting columnSorting [React 16] renders a toolbar but
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-empty-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-desc"
title="High-Low"
type="button"
>
<span
Expand Down Expand Up @@ -433,6 +435,7 @@ exports[`useDataGridColumnSorting columnSorting [React 17] renders a toolbar but
aria-pressed="true"
class="euiButtonGroupButton euiButtonGroupButton-isSelected emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-fill-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-asc"
title="Low-High"
type="button"
>
<span
Expand All @@ -454,6 +457,7 @@ exports[`useDataGridColumnSorting columnSorting [React 17] renders a toolbar but
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-empty-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-desc"
title="High-Low"
type="button"
>
<span
Expand Down Expand Up @@ -709,6 +713,7 @@ exports[`useDataGridColumnSorting columnSorting [React 18] renders a toolbar but
aria-pressed="true"
class="euiButtonGroupButton euiButtonGroupButton-isSelected emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-fill-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-asc"
title="Low-High"
type="button"
>
<span
Expand All @@ -730,6 +735,7 @@ exports[`useDataGridColumnSorting columnSorting [React 18] renders a toolbar but
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-empty-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-desc"
title="High-Low"
type="button"
>
<span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ exports[`EuiDataGridColumnSortingDraggable [React 16] renders an EuiDraggable co
aria-pressed="true"
class="euiButtonGroupButton euiButtonGroupButton-isSelected emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-fill-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-asc"
title="Low-High"
type="button"
>
<span
Expand All @@ -115,6 +116,7 @@ exports[`EuiDataGridColumnSortingDraggable [React 16] renders an EuiDraggable co
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-empty-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-desc"
title="High-Low"
type="button"
>
<span
Expand Down Expand Up @@ -246,6 +248,7 @@ exports[`EuiDataGridColumnSortingDraggable [React 17] renders an EuiDraggable co
aria-pressed="true"
class="euiButtonGroupButton euiButtonGroupButton-isSelected emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-fill-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-asc"
title="Low-High"
type="button"
>
<span
Expand All @@ -267,6 +270,7 @@ exports[`EuiDataGridColumnSortingDraggable [React 17] renders an EuiDraggable co
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-empty-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-desc"
title="High-Low"
type="button"
>
<span
Expand Down Expand Up @@ -398,6 +402,7 @@ exports[`EuiDataGridColumnSortingDraggable [React 18] renders an EuiDraggable co
aria-pressed="true"
class="euiButtonGroupButton euiButtonGroupButton-isSelected emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-fill-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-asc"
title="Low-High"
type="button"
>
<span
Expand All @@ -419,6 +424,7 @@ exports[`EuiDataGridColumnSortingDraggable [React 18] renders an EuiDraggable co
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-empty-text"
data-test-subj="euiDataGridColumnSorting-sortColumn-columnA-desc"
title="High-Low"
type="button"
>
<span
Expand Down
20 changes: 8 additions & 12 deletions src/components/datagrid/controls/column_sorting_draggable.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,13 @@ describe('EuiDataGridColumnSortingDraggable', () => {
);

expect(
getByTestSubject(
'euiDataGridColumnSorting-sortColumn-columnA-asc'
)?.querySelector('[data-text]')?.textContent
getByTestSubject('euiDataGridColumnSorting-sortColumn-columnA-asc')
.title
).toEqual('A-Z');

expect(
getByTestSubject(
'euiDataGridColumnSorting-sortColumn-columnA-desc'
)?.querySelector('[data-text]')?.textContent
getByTestSubject('euiDataGridColumnSorting-sortColumn-columnA-desc')
.title
).toEqual('Z-A');
});

Expand All @@ -133,15 +131,13 @@ describe('EuiDataGridColumnSortingDraggable', () => {
);

expect(
getByTestSubject(
'euiDataGridColumnSorting-sortColumn-columnA-asc'
)?.querySelector('[data-text]')?.textContent
getByTestSubject('euiDataGridColumnSorting-sortColumn-columnA-asc')
.title
).toEqual('False-True');

expect(
getByTestSubject(
'euiDataGridColumnSorting-sortColumn-columnA-desc'
)?.querySelector('[data-text]')?.textContent
getByTestSubject('euiDataGridColumnSorting-sortColumn-columnA-desc')
.title
).toEqual('True-False');
});
});
Expand Down

0 comments on commit a1a5835

Please sign in to comment.