[PR feedback] arrow syntax as opposed to function syntax

+ slightly clearer function names
elastic · Feb 5, 2024 · 58c4644 · 58c4644
1 parent ac3ddd6
commit 58c4644
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 65 deletions.
diff --git a/src/components/table/table_footer_cell.test.tsx b/src/components/table/table_footer_cell.test.tsx
@@ -15,15 +15,14 @@ import { EuiTableFooterCell } from './table_footer_cell';
 import { CENTER_ALIGNMENT, RIGHT_ALIGNMENT } from '../../services';
 import { WARNING_MESSAGE } from './utils';
 
-function renderTable(ui: React.ReactElement) {
-  return render(
+const renderInTableFooter = (cell: React.ReactElement) =>
+  render(
     <table>
       <tfoot>
-        <tr>{ui}</tr>
+        <tr>{cell}</tr>
       </tfoot>
     </table>
   );
-}
 
 describe('EuiTableFooterCell', () => {
   const _consoleWarn = console.warn;
@@ -39,7 +38,7 @@ describe('EuiTableFooterCell', () => {
   });
 
   test('is rendered', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableFooter(
       <EuiTableFooterCell {...requiredProps}>children</EuiTableFooterCell>
     );
 
@@ -48,21 +47,21 @@ describe('EuiTableFooterCell', () => {
 
   describe('align', () => {
     test('defaults to left', () => {
-      const { container } = renderTable(<EuiTableFooterCell />);
+      const { container } = renderInTableFooter(<EuiTableFooterCell />);
 
       expect(container.firstChild).toMatchSnapshot();
     });
 
     test('renders right when specified', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableFooter(
         <EuiTableFooterCell align={RIGHT_ALIGNMENT} />
       );
 
       expect(container.firstChild).toMatchSnapshot();
     });
 
     test('renders center when specified', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableFooter(
         <EuiTableFooterCell align={CENTER_ALIGNMENT} />
       );
 
@@ -72,31 +71,31 @@ describe('EuiTableFooterCell', () => {
 
   describe('width and style', () => {
     test('accepts style attribute', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableFooter(
         <EuiTableFooterCell style={{ width: '20%' }}>Test</EuiTableFooterCell>
       );
 
       expect(container.firstChild).toMatchSnapshot();
     });
 
     test('accepts width attribute', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableFooter(
         <EuiTableFooterCell width="10%">Test</EuiTableFooterCell>
       );
 
       expect(container.firstChild).toMatchSnapshot();
     });
 
     test('accepts width attribute as number', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableFooter(
         <EuiTableFooterCell width={100}>Test</EuiTableFooterCell>
       );
 
       expect(container.firstChild).toMatchSnapshot();
     });
 
     test('resolves style and width attribute', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableFooter(
         <EuiTableFooterCell width="10%" style={{ width: '20%' }}>
           Test
         </EuiTableFooterCell>

diff --git a/src/components/table/table_header_cell.test.tsx b/src/components/table/table_header_cell.test.tsx
@@ -15,47 +15,48 @@ import { EuiTableHeaderCell } from './table_header_cell';
 import { RIGHT_ALIGNMENT, CENTER_ALIGNMENT } from '../../services';
 import { WARNING_MESSAGE } from './utils';
 
-function renderTable(ui: React.ReactElement) {
-  return render(
+const renderInTableHeader = (cell: React.ReactElement) =>
+  render(
     <table>
       <thead>
-        <tr>{ui}</tr>
+        <tr>{cell}</tr>
       </thead>
     </table>
   );
-}
 
 test('renders EuiTableHeaderCell', () => {
-  const { container } = renderTable(
+  const { container } = renderInTableHeader(
     <EuiTableHeaderCell {...requiredProps}>children</EuiTableHeaderCell>
   );
 
   expect(container.firstChild).toMatchSnapshot();
 });
 
 test('renders td when children is null/undefined', () => {
-  const { container } = renderTable(<EuiTableHeaderCell {...requiredProps} />);
+  const { container } = renderInTableHeader(
+    <EuiTableHeaderCell {...requiredProps} />
+  );
 
   expect(container.firstChild).toMatchSnapshot();
 });
 
 describe('align', () => {
   test('defaults to left', () => {
-    const { container } = renderTable(<EuiTableHeaderCell />);
+    const { container } = renderInTableHeader(<EuiTableHeaderCell />);
 
     expect(container.firstChild).toMatchSnapshot();
   });
 
   test('renders right when specified', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell align={RIGHT_ALIGNMENT} />
     );
 
     expect(container.firstChild).toMatchSnapshot();
   });
 
   test('renders center when specified', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell align={CENTER_ALIGNMENT} />
     );
 
@@ -65,15 +66,15 @@ describe('align', () => {
 
 describe('sorting', () => {
   test('is rendered with isSorted', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell isSorted>Test</EuiTableHeaderCell>
     );
 
     expect(container.firstChild).toMatchSnapshot();
   });
 
   test('is rendered with isSortAscending', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell isSorted isSortAscending>
         Test
       </EuiTableHeaderCell>
@@ -83,7 +84,7 @@ describe('sorting', () => {
   });
 
   test('renders a button with onSort', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell isSorted onSort={() => {}}>
         Test
       </EuiTableHeaderCell>
@@ -93,7 +94,7 @@ describe('sorting', () => {
   });
 
   test('does not render a button with readOnly', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell readOnly isSorted onSort={() => {}}>
         Test
       </EuiTableHeaderCell>
@@ -117,31 +118,31 @@ describe('width and style', () => {
   });
 
   test('accepts style attribute', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell style={{ width: '20%' }}>Test</EuiTableHeaderCell>
     );
 
     expect(container.firstChild).toMatchSnapshot();
   });
 
   test('accepts width attribute', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell width="10%">Test</EuiTableHeaderCell>
     );
 
     expect(container.firstChild).toMatchSnapshot();
   });
 
   test('accepts width attribute as number', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell width={100}>Test</EuiTableHeaderCell>
     );
 
     expect(container.firstChild).toMatchSnapshot();
   });
 
   test('resolves style and width attribute', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCell width="10%" style={{ width: '20%' }}>
         Test
       </EuiTableHeaderCell>

diff --git a/src/components/table/table_header_cell_checkbox.test.tsx b/src/components/table/table_header_cell_checkbox.test.tsx
@@ -13,15 +13,14 @@ import { render } from '../../test/rtl';
 import { EuiTableHeaderCellCheckbox } from './table_header_cell_checkbox';
 import { WARNING_MESSAGE } from './utils';
 
-function renderTable(ui: React.ReactElement) {
-  return render(
+const renderInTableHeader = (cell: React.ReactElement) =>
+  render(
     <table>
       <thead>
-        <tr>{ui}</tr>
+        <tr>{cell}</tr>
       </thead>
     </table>
   );
-}
 
 describe('EuiTableHeaderCellCheckbox', () => {
   const _consoleWarn = console.warn;
@@ -37,7 +36,7 @@ describe('EuiTableHeaderCellCheckbox', () => {
   });
 
   test('is rendered', () => {
-    const { container } = renderTable(
+    const { container } = renderInTableHeader(
       <EuiTableHeaderCellCheckbox {...requiredProps} />
     );
 
@@ -46,7 +45,7 @@ describe('EuiTableHeaderCellCheckbox', () => {
 
   describe('width and style', () => {
     test('accepts style attribute', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableHeader(
         <EuiTableHeaderCellCheckbox style={{ width: '20%' }}>
           Test
         </EuiTableHeaderCellCheckbox>
@@ -56,7 +55,7 @@ describe('EuiTableHeaderCellCheckbox', () => {
     });
 
     test('accepts width attribute', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableHeader(
         <EuiTableHeaderCellCheckbox width="10%">
           Test
         </EuiTableHeaderCellCheckbox>
@@ -66,7 +65,7 @@ describe('EuiTableHeaderCellCheckbox', () => {
     });
 
     test('accepts width attribute as number', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableHeader(
         <EuiTableHeaderCellCheckbox width={100}>
           Test
         </EuiTableHeaderCellCheckbox>
@@ -76,7 +75,7 @@ describe('EuiTableHeaderCellCheckbox', () => {
     });
 
     test('resolves style and width attribute', () => {
-      const { container } = renderTable(
+      const { container } = renderInTableHeader(
         <EuiTableHeaderCellCheckbox width="10%" style={{ width: '20%' }}>
           Test
         </EuiTableHeaderCellCheckbox>

diff --git a/src/components/table/table_row.test.tsx b/src/components/table/table_row.test.tsx
@@ -14,16 +14,15 @@ import { EuiTableRow } from './table_row';
 
 import { EuiTableRowCell } from './table_row_cell';
 
-function renderTable(ui: React.ReactElement) {
-  return render(
+const renderInTable = (row: React.ReactElement) =>
+  render(
     <table>
-      <tbody>{ui}</tbody>
+      <tbody>{row}</tbody>
     </table>
   );
-}
 
 test('renders EuiTableRow', () => {
-  const { container } = renderTable(
+  const { container } = renderInTable(
     <EuiTableRow {...requiredProps}>
       <EuiTableRowCell>hi</EuiTableRowCell>
     </EuiTableRow>
@@ -34,7 +33,7 @@ test('renders EuiTableRow', () => {
 
 describe('isSelected', () => {
   test('renders true when specified', () => {
-    const { container } = renderTable(
+    const { container } = renderInTable(
       <EuiTableRow isSelected={true}>
         <EuiTableRowCell />
       </EuiTableRow>