[EuiPagination] Add keys for EuiI18n values in compressed count text (#…

…8243)
elastic · Jan 7, 2025 · 41cf816 · 41cf816
1 parent 2b08104
commit 41cf816
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/eui/changelogs/upcoming/8243.md b/packages/eui/changelogs/upcoming/8243.md
@@ -0,0 +1,3 @@
+**Bug fixes**
+
+- Ensures that the `values` of `EuiI18n` used in `EuiPagination` use `key` attributes to prevent potential ["unique key" warnings](https://react.dev/learn/rendering-lists#keeping-list-items-in-order-with-key).
diff --git a/packages/eui/src/components/pagination/pagination.tsx b/packages/eui/src/components/pagination/pagination.tsx
@@ -159,8 +159,8 @@ export const EuiPagination: FunctionComponent<Props> = ({
             token="euiPagination.pageOfTotalCompressed"
             default="{page} of {total}"
             values={{
-              page: <span>{activePage + 1}</span>,
-              total: <span>{pageCount}</span>,
+              page: <span key="activePage">{activePage + 1}</span>,
+              total: <span key="pageCount">{pageCount}</span>,
             }}
           />
         </EuiText>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bug fixes

		- Ensures that the `values` of `EuiI18n` used in `EuiPagination` use `key` attributes to prevent potential ["unique key" warnings](https://react.dev/learn/rendering-lists#keeping-list-items-in-order-with-key).