Skip to content

Commit

Permalink
[misc] CSS fixes/cleanup
Browse files Browse the repository at this point in the history
- Fix padding on compressed plain text selections (does not affect pills)

- Remove unnecessary `hover` pseudo around cursor (by default they only show on hover) and fix pills to also use the correct cursor when disabled
  • Loading branch information
cee-chen committed Nov 1, 2023
1 parent 952a6f5 commit 252fdfb
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/components/combo_box/_combo_box.scss
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,7 @@
height: auto; /* 3 */
flex-wrap: wrap; /* 1 */
align-content: flex-start;

&:hover {
cursor: text;
}
cursor: text;
}

&.euiComboBox__inputWrap--noWrap {
Expand Down Expand Up @@ -126,16 +123,17 @@
}

// overrides the `cursor: text;` that displays on hover for combo boxes that allow multiple pills
.euiComboBox__inputWrap:not(.euiComboBox__inputWrap--noWrap):hover {
.euiComboBox__inputWrap,
.euiComboBoxPill {
cursor: not-allowed;
}
}

&.euiComboBox--compressed {
.euiComboBox__inputWrap {
line-height: $euiFormControlCompressedHeight; /* 2 */
padding-top: 0;
padding-bottom: 0;
padding-block: 0;
padding-inline-start: $euiSizeXS;
}
}
}

0 comments on commit 252fdfb

Please sign in to comment.