Skip to content

Commit

Permalink
Adding EuiTabs guidance cross-link to EuiBreadcrumbs.
Browse files Browse the repository at this point in the history
  • Loading branch information
1Copenut committed Dec 7, 2023
1 parent 738a054 commit 15cb350
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
7 changes: 7 additions & 0 deletions src-docs/src/views/breadcrumbs/breadcrumbs_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ export const BreadcrumbsExample = {
</Link>{' '}
should be used for application-wide navigation.
</p>
<p>
See{' '}
<Link to="/navigation/tabs/guidelines">
<strong>EuiTabs guidelines</strong>
</Link>{' '}
if your application requires breadcrumbs and tabs on the same view.
</p>
</EuiText>
),
sections: [
Expand Down
10 changes: 8 additions & 2 deletions src-docs/src/views/tabs/tabs_guidance.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import { Link } from 'react-router-dom';

import {
EuiCode,
Expand Down Expand Up @@ -42,8 +43,13 @@ export default () => (
<h3>Tabs must not update higher-level navigation</h3>
<p>
Do not update navigation such as{' '}
<EuiLink href="/#/navigation/breadcrumbs">breadcrumbs</EuiLink> or{' '}
<EuiLink href="/#/navigation/collapsible-nav">navigation menus</EuiLink>{' '}
<Link to="/navigation/breadcrumbs">
<strong>breadcrumbs</strong>
</Link>{' '}
or{' '}
<Link to="/navigation/collapsible-nav">
<strong>navigation menus</strong>
</Link>{' '}
when users click on tabs. Tabs show localized information and it is not
always clear what changed if tabs are below the fold or navigation does
not match the route.
Expand Down

0 comments on commit 15cb350

Please sign in to comment.