Relax limit on max string size #96031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackson 2.15 introduced a (rough) maximum limit on string length. This commit relaxes that limit to its maximum size, leaving document size constraints to other existing limits in the system. We can revisit whether string length within a document should be independently constrainted later.
rjernst
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
I've marked this as a non-issue because it will target 8.8.0 where this regression was introduced. |
💚 Backport successful
|
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 11, 2023
Jackson 2.15 introduced a (rough) maximum limit on string length. This commit relaxes that limit to its maximum size, leaving document size constraints to other existing limits in the system. We can revisit whether string length within a document should be independently constrainted later.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 11, 2023
Jackson 2.15 introduced a (rough) maximum limit on string length. This commit relaxes that limit to its maximum size, leaving document size constraints to other existing limits in the system. We can revisit whether string length within a document should be independently constrainted later.
This was referenced May 12, 2023
rshen91
added a commit
to elastic/kibana
that referenced
this pull request
May 16, 2023
## Summary Closes #156901, #156902, and #156106 As Tim discovered and mentioned in 156901 - these suite of tests were skipped because of a new limit that was reverted in es elastic/elasticsearch#96031 Tests pass without any problems now.
jasonrhodes
pushed a commit
to elastic/kibana
that referenced
this pull request
May 17, 2023
## Summary Closes #156901, #156902, and #156106 As Tim discovered and mentioned in 156901 - these suite of tests were skipped because of a new limit that was reverted in es elastic/elasticsearch#96031 Tests pass without any problems now.
|
I'm wondering if this limit is taken into account for the ingest attachment plugin. According to the discussion here: https://discuss.elastic.co/t/345687 it seems that Jackson is still using its default limit of 5mb (with jackson 2.15.0):
Do we need to also modify some code in the ingest pipeline plugin? BTW, Jackson has modified this limit to 20mb in 2.15.1. May be we should upgrade Jackson? 2.15.3 seems to be the latest stable version... |
|
Hi, @dadoonet please cut an issue if this remains a problem. It's hard for us to track issues if they exist as comments on a PR several months after it's been merged. |
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Jan 4, 2024
Remove the rough limit on string length from Jackson 2.15. The limit was already relaxed for JSON in elastic#96031, this extends that change to other XContent types. Refs: elastic#96031
This was referenced Jan 4, 2024
stu-elastic
added a commit
that referenced
this pull request
Jan 8, 2024
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Jan 8, 2024
Remove the rough limit on string length from Jackson 2.15. The limit was already relaxed for JSON in elastic#96031, this extends that change to other XContent types. Refs: elastic#96031 Fixes: elastic#104009 (cherry picked from commit a359b1f)
|
Was it backported to Elasticsearch 7 as well? Could you please backport it, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackson 2.15 introduced a (rough) maximum limit on string length. This commit relaxes that limit to its maximum size, leaving document size constraints to other existing limits in the system. We can revisit whether string length within a document should be independently constrained later.
Fixes #96036