-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Tidy up some unused components #93565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-delivery (Team:Delivery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you identify the items to remove? The tricky thing with this file is if you regenerate it from scratch, it'll only include artifacts that were resolved in the current build. We have lots of different possible tasks to execute that all require different artifacts and some are even host platform specific so it's hard to create a single build that constitutes all possible required artifacts. That's why creating the iniital file was a bit of a game of trial and error.
Trial and error -- I cleared out all the components and then pushed a build through, adding things back in until I got CI to go green. |
Replaces #93557
A bit of followup from #93522 and #93438, I noticed some unused components hanging around, so I did a round of tree-shaking to see what could be dropped.