Skip to content

Fix BWC version to 8.3.0 #85580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

joegallo
Copy link
Contributor

After #85524 landed in 8.2, I suspect that we need to bump this version on master, but I'm not actually 100% certain. Better to have this PR passing tests and ready to merge, though.

@joegallo joegallo added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.3.0 labels Mar 31, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Mar 31, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@joegallo
Copy link
Contributor Author

I'm seeing this from a failed Jenkins bwc test, which is why I figured this might be it:

fatal error in thread [Thread-23], exiting
»  java.lang.AssertionError: java.lang.IllegalArgumentException: Unknown NamedWriteable [org.elasticsearch.xpack.core.XPackFeatureSet$Usage][archive]
»  	at org.elasticsearch.transport.InboundHandler.handleResponse(InboundHandler.java:346)
»  	at org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:142)
»  	at org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:94)
»  	at org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:795)
»  	at org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:149)
»  	at org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:121)
»  	at org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:86)
»  	at org.elasticsearch.transport.netty4.Netty4MessageInboundHandler.channelRead(Netty4MessageInboundHandler.java:63)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
»  	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
»  	at io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
»  	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
»  	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
»  	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
»  	at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1372)
»  	at io.netty.handler.ssl.SslHandler.decodeJdkCompatible(SslHandler.java:1235)
»  	at io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1284)
»  	at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
»  	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
»  	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
»  	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
»  	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
»  	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
»  	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
»  	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
»  	at io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:623)
»  	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:586)
»  	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
»  	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
»  	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
»  	at java.base/java.lang.Thread.run(Thread.java:833)
»  Caused by: java.lang.IllegalArgumentException: Unknown NamedWriteable [org.elasticsearch.xpack.core.XPackFeatureSet$Usage][archive]
»  	at org.elasticsearch.common.io.stream.NamedWriteableRegistry.getReader(NamedWriteableRegistry.java:112)
»  	at org.elasticsearch.common.io.stream.NamedWriteableAwareStreamInput.readNamedWriteable(NamedWriteableAwareStreamInput.java:36)
»  	at org.elasticsearch.common.io.stream.NamedWriteableAwareStreamInput.readNamedWriteable(NamedWriteableAwareStreamInput.java:28)
»  	at org.elasticsearch.common.io.stream.StreamInput.readNamedWriteableList(StreamInput.java:1190)
»  	at org.elasticsearch.xpack.core.action.XPackUsageResponse.<init>(XPackUsageResponse.java:27)
»  	at org.elasticsearch.action.ActionListenerResponseHandler.read(ActionListenerResponseHandler.java:58)
»  	at org.elasticsearch.action.ActionListenerResponseHandler.read(ActionListenerResponseHandler.java:25)
»  	at org.elasticsearch.transport.TransportService$UnregisterChildTransportResponseHandler.read(TransportService.java:1623)
»  	at org.elasticsearch.transport.TransportService$UnregisterChildTransportResponseHandler.read(TransportService.java:1598)
»  	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.read(TransportService.java:1331)
»  	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.read(TransportService.java:1318)
»  	at org.elasticsearch.transport.InboundHandler.handleResponse(InboundHandler.java:338)
»  	... 39 more
»  ERROR: Elasticsearch did not exit normally - check the logs at /dev/shm/elastic+elasticsearch+main+intake+multijob+bwc-snapshots/x-pack/qa/rolling-upgrade/build/testclusters/v8.2.0-2/logs/v8.2.0.log
»   ↓ last 

But I haven't been able to reproduce that failure locally yet, so this is PR is a bit of a guess. 😕

@joegallo joegallo requested review from mark-vieira and ywelsch March 31, 2022 22:16
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joegallo joegallo merged commit eb58008 into elastic:master Mar 31, 2022
@joegallo joegallo deleted the fix-bwc-after-85524 branch March 31, 2022 23:04
@ywelsch
Copy link
Contributor

ywelsch commented Apr 1, 2022

Thank you for the quick fix, Joe, and thank you for the quick review, Nhat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants