Add recovery gate to GET /_recovery response - #158774
Draft
samxbr wants to merge 3 commits into
Draft
Conversation
samxbr
commented
Sep 8, 2026
Comment on lines
68
to
+72
| public Map<String, List<RecoveryState>> shardRecoveryStates() { | ||
| return shardRecoveryStates; | ||
| return Maps.transformValues( | ||
| shardRecoveryInfos, | ||
| infos -> infos.stream().map(ShardRecoveryInfo::recoveryState).collect(Collectors.toCollection(ArrayList::new)) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This method should just return Map<String, List<ShardRecoveryInfo>>, but there are too many references and will make this PR difficult to review, I will refactor this in a follow-up.
samxbr
added
:Distributed/Recovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes a new optional field
gateto the response of theGET /_recoveryAPI, showing the name of the recovery gate blocking shard recovery. Notable changes:TransportRecoveryActioncaptures a snapshot of pending recoveries and gate fromThrottlingRecoveryServiceasnodeContextto to construct the shard level responseRecoveryStatereturned inRecoveryResponseis wrapped in a newShardRecoveryInfo, to include the node level recovery gateRelates to https://github.com/elastic/elasticsearch-team/issues/4477