-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Simplified Linear & RRF Retrievers - Return error on empty fields param #129962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified Linear & RRF Retrievers - Return error on empty fields param #129962
Conversation
Pinging @elastic/search-eng (Team:SearchOrg) |
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Hi @Mikep86, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
@elasticmachine update branch |
💚 Backport successful
|
Updates the simplified
linear
&rrf
retrievers to return an error when thefields
param is empty:Previously, this would query all fields specified by
index.query.default_field
, but this creates a potential future problem with supporting combinations ofquery
andretrievers
, like this:In contrast, this should (at most) only execute the custom sub-retrievers and not query any fields for "Harry Potter". Returning an error for now when the
fields
param is empty gives us more options for how to combinequery
andretrievers
in the future.