Tests demonstrating inconsistencies in error handling when skip_unavailable=true #129957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to the recent skip_unavailable=true change, there's still an inconsistency there. The change in #128163 covers most runtime errors, however it does not cover one code path, namely the one covered by
CssPartialErrorsActionListener.onFailure
- which handles failures that happen inanalyzedPlan
. There the code still has this condition:which controls the code path where all remotes that we tried when attempting to resolve index failed, and we're about to return an empty result (we're talking about skip_unavailable=true here).
However, if the error that happened on the remote is not a disconnect error but some other error, unlike the runtime branch,
skip_unavailable=true
would not cover it, and we would still return a failure.In addition to that, when other indices are present, the same error would instead be hidden by
mergedMappings
because it is currently only processes unavailability errors.